-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adjust to make install M1 compatible #85
base: master
Are you sure you want to change the base?
Conversation
Homebrew on M1 uses /opt/homebrew rather than /usr/local. This change updates the extconf.rb to point to the correct library location.
Bump the versions
Is there any blocker to getting this PR merged? Thanks |
Naive question, @aledalgrande what happens for linux users if PR looks good otherwise. @dkam thanks for including a the version bump along with the changes. |
AFAIK passing an |
The library isn't setup to test PRs at this point, so this hasn't been automatically tested within Travis CI, https://travis-ci.org/github/westonplatter/phashion/branches. |
Interesting I thought Travis would build branches by default. Your conf doesn't exclude branches. |
Oh wait it does: https://travis-ci.org/github/westonplatter/phashion/pull_requests |
Score. I don't see a CI Test Suite run for this PR. My guess is the integration needs to get looked at. Any ideas? |
Are you able to log in and add the project in the new travis-ci.com site? Seems like the one you linked is deprecated. I don't have the credentials for the repo so I can't investigate or try to trigger a build. |
yep. Might be a day or two (tied up at work). |
Hey, no worries if you don't have time, but just checking back to put this on your radar. |
TravisCI requires a credit card and will eventually bill for projects after a certain point, therefore, moving to a different free CI. Github Actions seems good enough and was able to get it up and running with minimal copy/paste from examples. I'd be happy to merge the PR once a rebase on this PR pulls in #88 changes and shows no regressions. |
Update the ext code to look in the new Homebrew path on M1